1016 frontend ability for users to manually enter pii to an in progress subject request #1377
Conversation
| loadingText="Submitting" | ||
| size="sm" | ||
| variant="solid" | ||
| type="submit" |
There was a problem hiding this comment.
On first load, it seems like you can't submit the drawer with empty fields. You can submit it with text, save, and then come back a second time and edit it to a empty string and then save but I'd think you should be able to submit originally with all empty fields.
In my understanding it's okay if all of the fields are empty and they submit. The backend just cares that they made a submission, even if they are all empty. It's possible that they looked for fields and none existed.
There was a problem hiding this comment.
I have updated the drawer to have the Submit button disabled until the user has entered value(s) which are not deeply equal from the initial form values. Let me know if this makes sense.
| _hover={{ bg: "primary.400" }} | ||
| _active={{ bg: "primary.500" }} | ||
| > | ||
| Complete DSR |
There was a problem hiding this comment.
Wanted to point out an edge case. If someone goes and edits the original dsr package labels for the manual webhook (can only be done through the API currently), and we've already saved values for the webhook for a given privacy request here, we will not be able to complete the DSR here.
In other words, if we've changed which fields we've said we want to upload to the user, but we have a different set of fields saved, it errors rather than return these different fields to the user. A 429 is thrown when you try to resume.
Ideally, I think they'd need to reupload the correct fields for the offending collection, this might be a combination of backend and frontend changes to resolve.
There was a problem hiding this comment.
A related issue, if you refresh this page and there is a mismatch between the values saved for the privacy request and the dsr_package_labels for the webhook, it looks like you can't open the subject request detail page at all.
The detail I return for this particular error is pretty indicative of where the error is. I'd rework to still allow this page to reload if this occurs and maybe show them an empty set of fields that need to be rewritten.
I can chat about potential backend changes too to help with this state if needed.
There was a problem hiding this comment.
Thanks for pointing out this user scenario. Let's discuss the edge case scenario(s) with @seanpreston tomorrow if possible. Once manual input data has been uploaded, not sure if a user should be able to edit the DSR Package Label value accordingly.
There was a problem hiding this comment.
Discussed in person, we'll put in this backend ticket to resolve #1389
| You don‘t have any Manual Webhook connections | ||
| set up yet. |
There was a problem hiding this comment.
This is another edge case. I created a webhook, ran a privacy request (which put this in requires_input) and then went back to my connectors page and deleted the webhook. Now there's no way to resume this privacy request.
I wonder if we should show different text here, and allow them to resume. They did have a webhook, but now it's gone. It can be resumed from a backend perspective.
There was a problem hiding this comment.
One possible solution for this edge case is to disable the feature for a user to be able to Delete a Webhook connection if one or more Subject Request records have manual input data entered. Let's discuss this further.
There was a problem hiding this comment.
Discussed in person, we'll put in this backend ticket to resolve #1388
| {key} | ||
| </FormLabel> | ||
| <Input | ||
| {...field} |
There was a problem hiding this comment.
Input field works well, tested things like " and ✊🐝 Ꮆя𝐞ＥｔⓘŇｇ𝓢 ℱ𝔯Øϻ σᑌ𝓉𝕖𝕣 ѕρᗩ匚ᵉ 🍭 empty fields and random code.
Wanted to get your opinion, should we limit the text we can upload here? Since you need to be able to login to fidesops I doubt people would paste novels into this block.
There was a problem hiding this comment.
@pattisdr Great suggestion. What are the current DB field constraints for these? Once I have the character limitiations, I can implement the client side validation accordingly.
There was a problem hiding this comment.
I didn't add DB constraints on these particular fields, I think if we did have limits they should be fairly high.
pattisdr
force-pushed
the
1016-frontend-ability-for-users-to-manually-enter-pii-to-an-in-progress-subject-request
branch
from
0893fbe to
273e110
Compare
…plays a validation error
…OGRESS subject request
…untime. User could not see visible horizontal line on UI before.
…OGRESS subject request
…OGRESS subject request
…OGRESS subject request
…he form is dirty.
chriscalhoun1974
force-pushed
the
1016-frontend-ability-for-users-to-manually-enter-pii-to-an-in-progress-subject-request
branch
from
5584b77 to
19c68d7
Compare
…reating a Manual Webhook
pattisdr
deleted the
1016-frontend-ability-for-users-to-manually-enter-pii-to-an-in-progress-subject-request
branch
1016.-.Frontend.ability.for.users.to.manually.enter.pii.to.an.in.progress.subject.request.webm
Purpose
For a given Subject Request record with a status of Requires Input, this UI feature allows a user to enter required manual input data to one or more Manual connections via the Subject Request detail screen (Manual Processing section). Once all of the given Manual connection(s) have the required manual input data entered, each Manual connection will be in a Review status. There will be a Complete DSR button displayed located below the last Manual connection record. Upon clicked, this will update the Subject Request record to a status of In Progress and the user will be redirected to the Subject Requests landing page.
Figma designs
https://www.figma.com/file/MTbZohIGvB4bq2f2wkiDHO/Fidesops-Management-UI?node-id=3458%3A48952
Changes
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1016