This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Fix Corner Case: Retrieving Access Results from Cache on Retry [#1348] #1349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix bug where erasure count confirmations may be returned instead of selected access request results when attempting to get access requests from the cache.
Because erasure requests are run after access requests, there normally aren't erasure results in the cache when we attempt to get access results. However, it's possible to run into this in the case of "restarting a privacy request from failure". If we were retrying a privacy request from a checkpoint that had already erased some data, we could possibly return erasure results instead of access results for selected collections, depending on if the access or erasure key was accessed last.
Changes
TaskResources.get_all_cached_objects
instead of using a key prefix that overlaps with erasure results.Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1348