This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Explicitly install the toml package
#1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this package was included as an indirect dependency only, but imported in source code as if it were a direct dependency. This led to installation issues for consumers of the `fidesops` `pip` package.
PSalant726
added
bug
PSalant726
force-pushed
the
explicitly-import-toml
branch
from
18f10f9 to
61bf674
Compare
sanders41
approved these changes
Sep 16, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Explicitly install `toml` as a requirement Previously this package was included as an indirect dependency only, but imported in source code as if it were a direct dependency. This led to installation issues for consumers of the `fidesops` `pip` package. * Reduce `toml` import volume * Update `CHANGELOG.md`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The
tomlpackage is not included inrequirements.txt, but is referenced in source code as a direct dependency:fidesops/src/fidesops/ops/core/config.py
Line 8 in a5d0ca8
This creates installation issues for anyone installing fidesops via
pip.Changes
tomltorequirements.txttomlimport volume inconfig.pyChecklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Related to ethyca/fidesops-plus#37