Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Manual Webhook Followup: UI Sync [#1326] #1323

Merged
merged 7 commits into from
Sep 16, 2022
Merged

Manual Webhook Followup: UI Sync [#1326] #1323

merged 7 commits into from
Sep 16, 2022

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Sep 14, 2022 •
edited
Loading

Purpose

Adjust some backend pieces as we test manual webhooks from a UI perspective.

Changes

  • Allow Manual Webhooks to be tested - by "testing" we just verify that a valid manual webhook config exists, with fields included.
  • Allow DSR Package labels to be supplied as empty strings, but then replace with an underscored/snake cased version of the PII field if this happens (requested by Chris)
  • Only run manual webhooks that have valid field configurations

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1326

@pattisdr pattisdr changed the title [DRAFT} Manual Webhook Followup: UI Sync [DRAFT] Manual Webhook Followup: UI Sync Sep 14, 2022
@pattisdr pattisdr changed the title [DRAFT] Manual Webhook Followup: UI Sync [DRAFT] Manual Webhook Followup: UI Sync [#1326] Sep 14, 2022
@pattisdr pattisdr changed the title [DRAFT] Manual Webhook Followup: UI Sync [#1326] Manual Webhook Followup: UI Sync [#1326] Sep 15, 2022
@pattisdr pattisdr marked this pull request as ready for review September 15, 2022 15:15
sanders41
sanders41 reviewed Sep 15, 2022
View reviewed changes
src/fidesops/ops/schemas/manual_webhook_schemas.py Show resolved Hide resolved
src/fidesops/ops/schemas/manual_webhook_schemas.py Show resolved Hide resolved
src/fidesops/ops/service/connectors/manual_webhook_connector.py Show resolved Hide resolved
src/fidesops/ops/service/connectors/manual_webhook_connector.py Show resolved Hide resolved
tests/ops/api/v1/endpoints/test_manual_webhooks.py Outdated Show resolved Hide resolved
tests/ops/api/v1/endpoints/test_manual_webhooks.py Outdated Show resolved Hide resolved
tests/ops/api/v1/endpoints/test_manual_webhooks.py Outdated Show resolved Hide resolved
tests/ops/models/test_manual_webhook.py Show resolved Hide resolved
tests/ops/models/test_manual_webhook.py Outdated Show resolved Hide resolved
@sanders41 sanders41 merged commit a5d0ca8 into main Sep 16, 2022
@sanders41 sanders41 deleted the manual_webhook_followup branch September 16, 2022 14:07
@pattisdr
Copy link
Contributor Author

thank you @sanders41!

sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@pattisdr
Manual Webhook Followup: UI Sync [#1326] (#1323)
65388a6 
* Make a manual webhook "testable" - which just asserts that a valid manual webhook configuration exists.

* Allow dsr_package_label to be an empty string but then convert to match pii field in that case.

* Changelog

* Respond to CR

* Fix mypy error.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sanders41 sanders41 sanders41 approved these changes

Assignees

@sanders41 sanders41

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual Webhook Backend Improvements Followup
2 participants
@pattisdr @sanders41