Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Change references to FIDESOPS__CONFIG_PATH to FIDES__CONFIG_PATH #1302

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Sep 12, 2022

Purpose

Change the references to FIDESOPS__CONFIG_PATH to the new name of FIDES__CONFIG_PATH.

Changes

  • Change references to FIDESOPS__CONFIG_PATH to FIDES_CONFIG_PATH in docs.

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #

@sanders41 sanders41 marked this pull request as ready for review September 12, 2022 20:17
@sanders41 sanders41 requested a review from a team September 12, 2022 20:19
@ThomasLaPiana
Copy link
Contributor

@sanders41 this is fixed in unified-fides already, not sure if consistency was something to do with it

@sanders41
Copy link
Contributor Author

@sanders41 this is fixed in unified-fides already, not sure if consistency was something to do with it

When fideslib was put in this variable name changed and we just noticed we forgot to update the docs to match

@ThomasLaPiana
Copy link
Contributor

just wanted to make sure!

@sanders41 sanders41 merged commit 7bdf0db into main Sep 13, 2022
@sanders41 sanders41 deleted the ps-config-file-docs branch September 13, 2022 14:31
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
* Change references to FIDESOPS__CONFIG_PATH to FIDES__CONFIG_PATH

* Update changelog

Co-authored-by: Paul Sanders <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants