-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
@sanders41 I updated the |
The property update looks good. I'll approve and merge as soon as CI finishes. |
@TheAndrewJackson one thing I just realized, this updates a database model. Do we need a migration? Maybe not since it is just a property? |
@sanders41 AFAIK we don't need a migration. We decided to calculate this property at the api level because it's a value that changes every day and there could be many changes if the org has a lot of privacy requests. It doesn't exist in the DB right now. If at a later date we decided to move this property into the DB and have an automated job that updated all the due dates we would need a migration. |
Purpose
Add dynamic
days_left
field that is generated based off of the currentdue_date
value of a privacy request.Changes
PrivacyRequest
modelChecklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1148