-
Notifications
You must be signed in to change notification settings - Fork 16
Make admin ui work when volumes are mounted #1266
Conversation
@sanders41 This command will need to be updated so it copies the files to the correct directory.
|
You run this outside docker right? So the correct path would be: |
Yes, this command is run from outside docker. I think it assumes that the directory it's copying to is mounted inside the docker container. I think this command won't work until we add another volume that mounts to the new What do you think of circling back and adding an equivalent command back if there is a need for it again? |
Sounds reasonable to me. I think it will be less needed after the update. |
* Make admin ui work when volumes are mounted * Update changelog * Fix path issue with hard refresh * Update from code review Co-authored-by: Paul Sanders <[email protected]>
Purpose
Mounting a volume overrides the files built in the container, the result of this is the admin ui files are deleted and can't load. This is to fix that issue.
Changes
generate_route_file_map
inmain.py
to work with the new directory structure.Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1235