This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Allows worker to start successfully in both dev and dev_with_worker #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eastandwestwind
commented
Sep 2, 2022
| build(session, "dev") | ||
| session.notify("teardown") | ||
| session.run("docker-compose", "up", "worker", "--wait", external=True) | ||
| session.run("docker-compose", "up", "--detach", "worker", external=True) |
There was a problem hiding this comment.
using the "--wait" flag properly: session.run("docker-compose", "up", "--wait", "worker", external=True) resulted in fidesops container never starting. This is because the wait flag will block until the current container exits (https://docs.docker.com/engine/reference/commandline/wait/). Celery container should not exit.
seanpreston
approved these changes
Sep 2, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
…1250) * Allows worker to start successfully in both dev and dev_with_worker * update changelog * formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allows worker to start successfully for both dev and dev_with_worker nox commands
Changes
FIDESOPS__EXECUTION__WORKER_ENABLEDconfig in docker-composedetachflag for starting up worker in separate container- https://docs.docker.com/engine/reference/commandline/compose_up/#description. This starts the worker container in the background and doesn't block the creation of fidesops container. Only downside is logs aren't visible in main shell where the nox commands are used, but you'll need todocker logs [container-id]to see celery logs.Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1249