Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add execution_timeframe to Policy model and schema #1244

Merged
merged 8 commits into from
Sep 2, 2022
Merged

Add execution_timeframe to Policy model and schema #1244

merged 8 commits into from
Sep 2, 2022

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Sep 1, 2022 •
edited
Loading

Purpose

Add execution_timeframe to Policy model and schema

Changes

  • Update Policy model and schema
  • Update Tests

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1146

@TheAndrewJackson TheAndrewJackson changed the title Add execution_timeframe column to model and schema Add execution_timeframe to Policy model and schema Sep 1, 2022
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review September 1, 2022 20:49
@seanpreston seanpreston self-assigned this Sep 2, 2022
@seanpreston seanpreston merged commit f0ef0fa into main Sep 2, 2022
@seanpreston seanpreston deleted the 1146_execution_timeframe_policy_model branch September 2, 2022 21:19
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@TheAndrewJackson
Add execution_timeframe to Policy model and schema (#1244)
2e17978 
* Add execution_timeframe column to model and schema

* Fix test failures

* Fix Policy patch route

* Update Policy patch test

* Run black and isort lints

* Update changelog

* fix typo

Co-authored-by: Sean Preston <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seanpreston seanpreston seanpreston approved these changes

Assignees

@seanpreston seanpreston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add execution_timeframe to Policy model
2 participants
@TheAndrewJackson @seanpreston