Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

[#1222] Fix reference in data categories upgrade migration #1223

Merged
merged 2 commits into from
Aug 30, 2022
Merged

[#1222] Fix reference in data categories upgrade migration #1223

merged 2 commits into from
Aug 30, 2022

Conversation

seanpreston
Copy link
Contributor

Purpose

Fixes a bug when running the 7abe778b7082_update_fideslang_data_categories_py migration:

INFO:fidesops.main:Running any pending DB migrations...
INFO:7abe778b7082_update_fideslang_data_categories_py:Upgrading fideslang categories
ERROR:fidesops.main:Connection to database failed: get() missing 1 required keyword-only argument: 'object_id'

Changes

  • Reference the DatasetConfig.dataset json correctly.

Ticket

Fixes #1222

@seanpreston seanpreston added the bug Something isn't working label Aug 30, 2022
@eastandwestwind
Copy link
Contributor

@seanpreston If you pull latest main, the mypy issue should be fixed - https://github.com/ethyca/fidesops/pull/1221/files#diff-f1e977da6504241080833ebd4544793ae30cf337b3b757df08d10b5e2668570cR309-R311

eastandwestwind
eastandwestwind approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note that this fixes both the upgrade and downgrade migration

@eastandwestwind eastandwestwind merged commit d4876d1 into main Aug 30, 2022
@eastandwestwind eastandwestwind deleted the 1222-fix-datacategory-migration branch August 30, 2022 22:14
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
fix reference in data categories upgrade migration (#1223)
be3b6b4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix incorrect reference in data_category upgrade migration
2 participants
@seanpreston @eastandwestwind