This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Build docker image for privacy center #1165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @sanders41 — this approach looks good |
sanders41
commented
Aug 30, 2022
@@ -43,3 +43,30 @@ jobs: | |||
- name: Push Prod Tags | |||
if: steps.check-tag.outputs.match == 'true' | |||
run: nox -s "push(prod)" | |||
push-fidesops-privacy-center-image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the Github documentation on this, but don't have any way to actually test it.
Comment on lines
54
to
55
username: ${{ env.DOCKER_USER }} # Needs updating for fidesops privacy center | ||
password: ${{ env.DOCKER_TOKEN }} # Needs updating for fidesops privacy center |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These will need to be updated for ethyca/fidesops-privacy-center
on docker hub
seanpreston
approved these changes
Aug 30, 2022
seanpreston
reviewed
Aug 30, 2022
seanpreston
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
sanders41
added a commit
that referenced
this pull request
Sep 22, 2022
* Build docker image for privacy center * Update docs and add docker publish to workflow * Update CHANGELOG * Move privacy center docker publish to its own workflow Co-authored-by: Paul Sanders <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create a docker image for the privacy center that can be published to docker hub.
I will updated docs etc once we are sure this is how we want things to work. For now to test cd to the privacy-center directory and build the container.
docker build -t privacy-center-test .
. Then run the containerdocker run --rm -p 3000:3000 privacy-center-test:latest
and navigate the http://localhost:3000 to verify things are running.Then in some other directory i.e.
~/test
create aconfig
folder then inside there create the following files:Then from within the test directory start the container with a volume mount
docker run --rm -v $(pwd)/config:/app/config -p 3000:3000 privacy-center-test:latest
. Navigate to http://localhost:3000 again and the privacy center should load, but with different colors this time.Changes
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1094