Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

hook up API request to logout action [Unticketed] #1139

Merged
merged 4 commits into from
Aug 25, 2022
Merged

hook up API request to logout action [Unticketed] #1139

merged 4 commits into from
Aug 25, 2022

Conversation

seanpreston
Copy link
Contributor

Purpose

The Fidesops authentication API is configured to invalidate tokens via calling of the /logout endpoint, this PR adds an API call to that endpoint when logout is called to properly invalidate the token, rather than only clearing the token from the application state.

Changes

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

chriscalhoun1974
chriscalhoun1974 approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seanpreston seanpreston marked this pull request as ready for review August 24, 2022 20:05
@seanpreston seanpreston merged commit 565a212 into main Aug 25, 2022
@seanpreston seanpreston deleted the logout-token-invalidation branch August 25, 2022 14:06
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
hook up API request to logout action [Unticketed] (#1139)
c9c3ff4 
* hook up API request to logout action

* run format

* update import orer

* add lint:fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriscalhoun1974 chriscalhoun1974 chriscalhoun1974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanpreston @chriscalhoun1974