Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Update Response Body for Saas Connection Instantiate [#814] #1105

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Aug 17, 2022

Purpose

This is a quick follow-up to #1076

#1076 added the ability to create a saas connector from a template. It creates a ConnectionConfig and a DatasetConfig. I returned a portion of the DatasetConfig in the response, but it would be useful to have information from the ConnectionConfig too after talking with @chriscalhoun1974

Changes

  • Update the response body to have both connection and dataset keys.

New Response

{
    "connection": {
        "name": "mailchimp connector 3",
        "key": "mailchimp_connector_3",
        "description": "Dev Mailchimp Instance",
        "connection_type": "saas",
        "access": "write",
        "created_at": "2022-08-17T19:17:35.001984+00:00",
        "updated_at": "2022-08-17T19:17:35.001984+00:00",
        "disabled": false,
        "last_test_timestamp": null,
        "last_test_succeeded": null,
        "saas_config": {
            "fides_key": "primary_mailchimp",
            "name": "Mailchimp SaaS Config",
            "type": "mailchimp"
        }
    },
    "dataset": {
        "fides_key": "primary_mailchimp",
        "organization_fides_key": "default_organization",
        "tags": null,
        "name": "Mailchimp Dataset",
        "description": "A sample dataset representing the Mailchimp connector for Fidesops",
        "meta": null,
        "data_categories": null,
        "data_qualifier": "aggregated.anonymized.unlinked_pseudonymized.pseudonymized.identified",
        "fidesctl_meta": null,
        "joint_controller": null,
        "retention": "No retention or erasure policy",
        "third_country_transfers": null,
        "collections": [
            ...
        ],
        "fidesops_meta": null
    }
}

Checklist

  • Update CHANGELOG.md file - changelog was updated in Create a Saas Connector from a Template [#814] #1076, this is just a quick follow-up to that PR.
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram. (documentation updated in Create a Saas Connector from a Template [#814] #1076
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #814

… of both the connection config and the dataset.
@pattisdr pattisdr changed the title Update Response Body for Saas Connection Instantiate Update Response Body for Saas Connection Instantiate [#814] Aug 17, 2022
@pattisdr pattisdr marked this pull request as ready for review August 17, 2022 19:37
@pattisdr
Copy link
Contributor Author

thank you so much @sanders41 !

@sanders41 sanders41 merged commit f7011e1 into main Aug 17, 2022
@sanders41 sanders41 deleted the fidesops_814_response_body branch August 17, 2022 20:22
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
… of both the connection config and the dataset. (#1105)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SaaS Connector Templates
2 participants