This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
983 Adds infra for email config and dispatch #1059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpreston
reviewed
Aug 10, 2022
seanpreston
reviewed
Aug 10, 2022
…supporting only 1 config, formatting
eastandwestwind
changed the title
WIP 983 email config POC
983 Adds infra for email config and dispatch
Aug 15, 2022
"""Enum for email service details""" | ||
|
||
# mailgun-specific | ||
IS_EU_DOMAIN = "is_eu_domain" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does EmailServiceDetails
need IS_SERVICE_DETAILS
when EmailServiceDetailsMailgun
has is_eu_domain
?
10 tasks
TheAndrewJackson
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Great job at making it modular. It should be straight forward to add more email providers in the future.
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Email config mvp crud / db layer * adds name to email config model * remove unintended changes * gets POC working * removes org name config var, updates crud endpoints to better handle supporting only 1 config, formatting * updates postman collection, adds to changelog, bumps downrev on migration * sort * formatting * use correct response model * Delete base.py * update migration annotation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Prove we can store email configs and send dummy MFA email using mailgun (actually implements much of the work needed for CRUD/db layer for email config)
Changes
Follow-ups / associated tickets:
EmailConfig
APIs #1086Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #983