-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
@PSalant726 I'm assuming that the CodeQL warning is getting triggered because of the new Path? |
documentation should have gotten updated here with the sweeping find and replaces, I'll take a look at what changed to double check though |
One thing I found in testing that I haven't found a reason for yet. I am having an issue with both Update: |
Looks like a false positive because our variables contain the literal word "secret" ? My guess is that we dismissed a similar warning before the path changed, and now CodeQL is picking it up again. The logging is not printing anything sensitive, so I think the warning can be dismissed. Someone with more context for this code should weigh in, just to be safe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one thing in the docs part that looks like it needs updating. Then every question after that is the same, are the .tmp
files supposed to be there?
So it looks like a lot but the answer will be the same for all but one of the comments, so no need to reply directly to every one of them.
src/fidesops/ops/api/v1/endpoints/encryption_endpoints.py.827d83b323422a5d52d4353baa6c6ea6.tmp
Outdated
Show resolved
Hide resolved
...esops/ops/api/v1/endpoints/user_permission_endpoints.py.2b43ed2f3cc70707c96dcf5ecc84456f.tmp
Outdated
Show resolved
Hide resolved
src/fidesops/ops/models/connectionconfig.py.9196cddd170c34bd83f70a0cd3a93da9.tmp
Outdated
Show resolved
Hide resolved
src/fidesops/ops/models/storage.py.a7149b26952db143a7fc69f5e8c46157.tmp
Outdated
Show resolved
Hide resolved
src/fidesops/ops/util/encryption/secrets_util.py.c78f77783bb8ed6ba4d595fafe4abb32.tmp
Outdated
Show resolved
Hide resolved
src/fidesops/ops/util/storage_authenticator.py.561093629ca233945ec694fb6cc060a1.tmp
Outdated
Show resolved
Hide resolved
tests/ops/schemas/test_user_permission.py.2807084f66f944f2946e52a024651201.tmp
Outdated
Show resolved
Hide resolved
tests/ops/util/encryption/test_hmac_encryption_scheme.py.489572ee3fc9884153f9619f1c4d75c9.tmp
Outdated
Show resolved
Hide resolved
tests/ops/test_helpers/cache_secrets_helper.py.b4d682a1bea8a757d49d14055d706429.tmp
Outdated
Show resolved
Hide resolved
@sanders41 Aha, I know what happened with all of those tmp files. The find & replace took a toll on my computer (100+ files and automatic formatting) and VS code crashed, I'm assuming where those all came from, as they were in limbo waiting to be saved or something. Will delete them and update the docs page |
Co-authored-by: Paul Sanders <[email protected]>
…com/ethyca/fidesops into ThomasLaPiana-reorg-appliation-code
@sanders41 I made some more thorough updates, would appreciate another review! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. A crash would do it with the tmp files. Sounds like it was a fun update 😄
@seanpreston this one looks read to merge to me whenever you think it would be a good time.
* Reorganize application code * first round of moving everything and updating the import paths * checkpoint, more path updates * more path updates * fix imports * fix isort * fix mypy, isort and setup.py issues * fix unsafe checks build step running on any label * update the changelog * delete temp files * Update docs/fidesops/docs/development/contributing_details.md Co-authored-by: Paul Sanders <[email protected]> * update more file references Co-authored-by: Paul Sanders <[email protected]>
Purpose
Reorganize the code to make the repo merger easier
Changes
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1005