Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Fix quickstart by using docker-compose run and docker network for all commands #1056

Merged
merged 1 commit into from
Aug 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions noxfiles/run_infrastructure.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def _run_quickstart(
"""
_run_cmd_or_err('echo "Running the quickstart..."')
_run_cmd_or_err(f"docker-compose {path} up -d")
_run_cmd_or_err(f"docker exec -it {service_name} python scripts/quickstart.py")
_run_cmd_or_err(f"docker-compose run {service_name} python scripts/quickstart.py")


def _run_create_superuser(
Expand All @@ -177,7 +177,7 @@ def _run_create_superuser(
_run_cmd_or_err('echo "Running create superuser..."')
_run_cmd_or_err(f"docker-compose {path} up -d")
_run_cmd_or_err(
f"docker exec -it {service_name} python scripts/create_superuser.py"
f"docker-compose run {service_name} python scripts/create_superuser.py"
)


Expand All @@ -191,7 +191,7 @@ def _run_create_test_data(
_run_cmd_or_err('echo "Running create test data..."')
_run_cmd_or_err(f"docker-compose {path} up -d")
_run_cmd_or_err(
f"docker exec -it {service_name} python scripts/create_test_data.py"
f"docker-compose run {service_name} python scripts/create_test_data.py"
)


Expand Down
2 changes: 1 addition & 1 deletion scripts/quickstart.py
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ def print_results(request_id: str) -> None:

# NOTE: In a real application, these secrets and config values would be provided
# via ENV vars or similar, but we've inlined everything here for simplicity
FIDESOPS_URL = "http://0.0.0.0:8080"
FIDESOPS_URL = "http://webserver:8080"
ROOT_CLIENT_ID = "fidesopsadmin"
ROOT_CLIENT_SECRET = "fidesopsadminsecret"

Expand Down