Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Backend Manual Webhooks: Distinguish Visited Webhooks #1350

Closed
pattisdr opened this issue Sep 19, 2022 · 0 comments · Fixed by #1339
Closed

Backend Manual Webhooks: Distinguish Visited Webhooks #1350

pattisdr opened this issue Sep 19, 2022 · 0 comments · Fixed by #1339
Assignees
Labels
enhancement New feature or request

Comments

@pattisdr
Copy link
Contributor

pattisdr commented Sep 19, 2022

Is your feature request related to a specific problem?

No fields are required to be entered for a manual webhook currently. Data may not exist for a particular subject, but we want the user to have verified they checked. For a manual webhook to be completed, at minimum, we need confirmation they looked at this (we cache an empty entry).

The Frontend currently can't distinguish between whether a webhook was visited and no results were found, or the webhook hasn't been visited at all.

@pattisdr pattisdr added the enhancement New feature or request label Sep 19, 2022
@pattisdr pattisdr self-assigned this Sep 19, 2022
seanpreston pushed a commit that referenced this issue Sep 20, 2022
* For UI purposes, when retrieving any manually input data, distinguish whether the user has confirmed they looked for data, in that they've manually uploaded something, even if everything was empty. In this case: checked=True.

* Prevent entering a pii or dsr_label as "      ".

* Fix unit test.

* Update Changelog.

Co-authored-by: Sean Preston <[email protected]>
sanders41 pushed a commit that referenced this issue Sep 22, 2022
* For UI purposes, when retrieving any manually input data, distinguish whether the user has confirmed they looked for data, in that they've manually uploaded something, even if everything was empty. In this case: checked=True.

* Prevent entering a pii or dsr_label as "      ".

* Fix unit test.

* Update Changelog.

Co-authored-by: Sean Preston <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant