This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Backend - Add manual webhook execution #1228
Labels
Comments
10 tasks
Remember to update the ERD diagram here along with other docs updates. Also Manual Webhooks are not associated with Policies as they were laid out in the initial design. See if resume instructions should be modified with this. |
Note: Instead of a paused state, these privacy requests are going to be put into a |
Assuming that there is no row inputs added, that there is one value that corresponds. This matches the mockups, but I'm not sure if this will match up in reality. In a pinch, data could be supplied comma-separated. |
10 tasks
eastandwestwind
pushed a commit
that referenced
this issue
Sep 13, 2022
* Add a method to cache data supplied for a manual webhook on a particular privacy request. * Add an endpoint to retrieve all enabled access manual webhooks. * Add an endpoint for uploading manual data corresponding to fields in a manual webhook for a given privacy request with "requires_input" status. * Add an endpoint to view data manually uploaded for an access manual webhook. - Add new scopes for the endpoints to upload/view manual data for webhooks. - Enforce that at least one field is added when defining a manual webhook, and add a fallback if no fields were defined. * Add an endpoint to resume a privacy request from "requires_input" status once all input has been added. None of the fields are required, but the a key for each manual webhook still needs to exist in the cache to proceed. As part of request execution check if data has been uploaded (data can be empty) for all manual webhooks. If True, we can proceed with request execution, otherwise, we put the PrivacyRequest in "requires_input" status and exits. Also adds the manual data uploaded directly to the packet we upload to the user at the very end. * Update postman collection. * Fix request_id query param in existing postman request. * Include additional details about how to resume a "requires_input" privacy request when getting its status. * Add docs and update changelog. * Upload new ERD diagram. * Don't put a privacy request in requires_input state if this policy only has erasure rules. * Respond to CR! * Update manual_webhooks.md
10 tasks
eastandwestwind
pushed a commit
that referenced
this issue
Sep 14, 2022
sanders41
pushed a commit
that referenced
this issue
Sep 22, 2022
* Add a method to cache data supplied for a manual webhook on a particular privacy request. * Add an endpoint to retrieve all enabled access manual webhooks. * Add an endpoint for uploading manual data corresponding to fields in a manual webhook for a given privacy request with "requires_input" status. * Add an endpoint to view data manually uploaded for an access manual webhook. - Add new scopes for the endpoints to upload/view manual data for webhooks. - Enforce that at least one field is added when defining a manual webhook, and add a fallback if no fields were defined. * Add an endpoint to resume a privacy request from "requires_input" status once all input has been added. None of the fields are required, but the a key for each manual webhook still needs to exist in the cache to proceed. As part of request execution check if data has been uploaded (data can be empty) for all manual webhooks. If True, we can proceed with request execution, otherwise, we put the PrivacyRequest in "requires_input" status and exits. Also adds the manual data uploaded directly to the packet we upload to the user at the very end. * Update postman collection. * Fix request_id query param in existing postman request. * Include additional details about how to resume a "requires_input" privacy request when getting its status. * Add docs and update changelog. * Upload new ERD diagram. * Don't put a privacy request in requires_input state if this policy only has erasure rules. * Respond to CR! * Update manual_webhooks.md
sanders41
pushed a commit
that referenced
this issue
Sep 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is your feature request related to a specific problem?
❗ Dependent on #1224
Add API endpoints and support for manual webhooks in the execution layer.
Describe the solution you'd like
Temporarily caching manual data received
privacy_request_id
and thepolicy_manual_webhook_id
, and store a dictionary of fields/values received.Execution
privacy_request_id
. If we don't have entries for all PolicyManualWebhooks, pause request execution.in_processing
, and queues the privacy request again from the "access step".upload_access_results
separately look up if there's any input data from anyPolicyManualWebhooks
in the cache and adds those directly to the filtered results with each key as the connection_config key. Unlike regular access results, these fields are just passed directly through, we don't filter on data category.Describe alternatives you've considered, if any
A description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: