Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Create Fidesops Email Connector and Example Email Dataset #1134

Closed
pattisdr opened this issue Aug 23, 2022 · 0 comments · Fixed by #1142
Closed

Create Fidesops Email Connector and Example Email Dataset #1134

pattisdr opened this issue Aug 23, 2022 · 0 comments · Fixed by #1142
Assignees
Labels
enhancement New feature or request Maildrop Connector

Comments

@pattisdr
Copy link
Contributor

pattisdr commented Aug 23, 2022

Is your feature request related to a specific problem?

Add the scaffolding for a new EmailConnector that will eventually send an email to a user to complete an action, instead of accessing a database or a third party endpoint automatically.

Describe the solution you'd like

  • Create a Fidesops EmailConnector class (inheriting from BaseConnector
    • Stub out query_config, create_client, close, test_connection, retrieve_data, and mask_data for now.
  • Add a schema migration that adds an "email" ConnectionType, so we can create email ConnectionConfigs
  • Flesh out an EmailSchema describing the types of secrets we should add to the Email ConnectionConfig. This will probably be very similar or identical to the EmailConfigRequest schema.
  • Create an example "email" dataset for use in testing. This will be similar to the existing "manual" dataset.
  • Add API tests verifying that we can create email ConnectionConfigs and add secrets to to the ConnectionConfig

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@pattisdr pattisdr added the enhancement New feature or request label Aug 23, 2022
@pattisdr pattisdr self-assigned this Aug 23, 2022
seanpreston pushed a commit that referenced this issue Aug 26, 2022
* Start a new "email" ConnectionConfig type.

* Hide "email" type from the get_connection_types endpoint for now, as the email connector isn't fleshed out yet.

* Update CHANGELOG.

* Simplify by sending one email to start?

* Update request body in postman collection.

* Fix CHANGELOG formatting.
sanders41 pushed a commit that referenced this issue Sep 22, 2022
* Start a new "email" ConnectionConfig type.

* Hide "email" type from the get_connection_types endpoint for now, as the email connector isn't fleshed out yet.

* Update CHANGELOG.

* Simplify by sending one email to start?

* Update request body in postman collection.

* Fix CHANGELOG formatting.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Maildrop Connector
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants