Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

OAuth Endpoint Description Awkward #110

Closed
RobertKeyser opened this issue Dec 1, 2021 · 0 comments · Fixed by #313
Closed

OAuth Endpoint Description Awkward #110

RobertKeyser opened this issue Dec 1, 2021 · 0 comments · Fixed by #313
Assignees
Labels
dev experience Enhancements to the overall DX good first issue Good for newcomers

Comments

@RobertKeyser
Copy link
Contributor

The phrasing of the description for /api/v1/oauth/token is a bit awkward.

"""Given a set of credentials, returns an access token if they are correct. Raises 401
exception if not"""

This clarifies that the "if not" has to do with the credentials and also adds a period.

- """Given a set of credentials, returns an access token if they are correct. Raises 401 exception if not"""
+    """Given a set of credentials, returns an access token if they are correct. Raises 401 exception if they are not."""
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dev experience Enhancements to the overall DX good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants