Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress tests for data category checkbox behavior #851

Merged
merged 22 commits into from
Jul 7, 2022
Merged

Cypress tests for data category checkbox behavior #851

merged 22 commits into from
Jul 7, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jul 6, 2022 •
edited
Loading

Closes #713

Code Changes

  • Add Cypress tests for the various checkbox tree behaviors
  • More data-testid's here and there

Steps to Confirm

  • nox -s dev then npm run cy:run

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

allisonking added 22 commits June 29, 2022 14:49
@allisonking
Initial cypress setup
f78190a
@allisonking
Make sure cypress artifacts don't sneak in
2ab4ecb
@allisonking
Configure cypress CI
7d84bb6
@allisonking
Add working directory and node matrix
bc8990d
@allisonking
Configure eslint to play nicely with cypress
0b3b84f
@allisonking
Configure cypress gh action
a171680
@allisonking
Add working directory
113c55d
@allisonking
Try to configure cypress again
1e01c9d
@allisonking
Fix wait-on url
73c2209
@allisonking
Clean up
5ee92f7
@allisonking
merge main
dd5b816
@allisonking
Add more cypress tests for dataset views
31719cd
@allisonking
More tests for viewing edit forms
0a9a768
@allisonking
Add test for editing a dataset field
10b8d72
@allisonking
Add more editing tests
cfbd389
@allisonking
Merge branch 'main' into aking-713-cypress-dataset-tests
7a09635
@allisonking
WIP checkbox tests
714973d
@allisonking
Merge branch 'main' into aking-713-cypress-checkbox
5b256e3
@allisonking
Add more checkbox tests
6e6e7da
@allisonking
Clean up
2cd6a9e
@allisonking
Try to reduce test flakiness in CI
8d77d6f
@allisonking
Configure to retry
79b780f
@allisonking allisonking marked this pull request as ready for review July 6, 2022 16:24
@allisonking allisonking requested a review from a team July 6, 2022 16:24
ThomasLaPiana
ThomasLaPiana approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice changes :)

@allisonking allisonking merged commit 40294f2 into main Jul 7, 2022
@allisonking allisonking deleted the aking-713-cypress-checkbox branch July 7, 2022 14:11
@allisonking allisonking mentioned this pull request Jul 7, 2022
Merged
allisonking added a commit that referenced this pull request Jul 28, 2022
@allisonking
Cypress tests for data category checkbox behavior (#851)
43fa28e 
* WIP checkbox tests

* Add more checkbox tests

* Clean up

* Try to reduce test flakiness in CI

* Configure to retry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasLaPiana ThomasLaPiana ThomasLaPiana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cypress tests for dataset management
2 participants
@allisonking @ThomasLaPiana