-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkbox tree fixes #760
Checkbox tree fixes #760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One small UX nit
@allisonking This is potentially for another issue but something I'd suggest from a UX perspective is that when I click "between" the arrow and the category itself (the dead space) it doesn't do anything. This felt unintuitive, as I'd expect it to either trigger the drop down (first choice) or select the category (second choice). Clicking on it and having nothing happened felt a bit off because the row was still highlighted |
Closes #743
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
There are a lot of UX things baked into this checkbox for our use case, so the easiest way to see if it is working as expected is probably just to play with it yourself. Hopefully the tests cover all of the cases too.
Screen.Recording.2022-06-14.at.1.46.52.PM.mov