-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an IdentifiabilityTag component #738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@allisonking i like this! An idea for the color-coding...maybe we could hash the string and convert that to a hex color code somehow? I guess that would go against the idea of having |
LKCSmith
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #702
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Important caveat: right now I am hardcoding the taxonomy based on the default taxonomy. I could pull this instead from the endpoint to any data qualifiers the user has added, but I'd need some guidance on what color non-default ones should be, and what label they should have. Label could perhaps be the last field in the dot notation? I'm guessing that ideally a user could choose their color/label, but then we would need an interface for them to be able to select that too. Or for color, wild idea, maybe we could do a yellow - red gradient based on how many dots the data qualifier has, since at least for the ones we have so far, the more nested it is, the more identifying the data is 🤔 In any case, depending on what we decide, we'll want another ticket separate from this one for it. FYI @mfbrown