Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an IdentifiabilityTag component #738

Merged
merged 18 commits into from
Jun 8, 2022
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 6, 2022

Closes #702

Code Changes

  • Adds a component for IdentifiabilityTag
  • Adds styling to data qualifier objects

Steps to Confirm

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

image

Important caveat: right now I am hardcoding the taxonomy based on the default taxonomy. I could pull this instead from the endpoint to any data qualifiers the user has added, but I'd need some guidance on what color non-default ones should be, and what label they should have. Label could perhaps be the last field in the dot notation? I'm guessing that ideally a user could choose their color/label, but then we would need an interface for them to be able to select that too. Or for color, wild idea, maybe we could do a yellow - red gradient based on how many dots the data qualifier has, since at least for the ones we have so far, the more nested it is, the more identifying the data is 🤔 In any case, depending on what we decide, we'll want another ticket separate from this one for it. FYI @mfbrown

@allisonking allisonking changed the base branch from main to aking-703-edit-field June 6, 2022 18:18
@allisonking allisonking marked this pull request as ready for review June 6, 2022 18:33
@allisonking allisonking requested review from a team and LKCSmith June 6, 2022 18:33
@ThomasLaPiana
Copy link
Contributor

@allisonking i like this!

An idea for the color-coding...maybe we could hash the string and convert that to a hex color code somehow? I guess that would go against the idea of having red = danger though?

Copy link
Contributor

@LKCSmith LKCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Base automatically changed from aking-703-edit-field to main June 8, 2022 18:26
@allisonking allisonking merged commit e3f9da2 into main Jun 8, 2022
@allisonking allisonking deleted the aking-702-identifiability-tag branch June 8, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build a special tag component for Identifiability
3 participants