Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset detail view #711

Merged
merged 6 commits into from
May 31, 2022
Merged

Dataset detail view #711

merged 6 commits into from
May 31, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented May 25, 2022

Closes (#700)

Code Changes

  • Add a page for dataset collections
  • Dropdown to select a collection
  • Render fields in a collection
  • Breadcrumbs
  • Pull data from /api/v1/dataset/{fides_key}
  • Be able to navigate to collections

Steps to Confirm

  • nox -s api
  • nox -s admin_ui
  • Navigate to http://localhost:3000/dataset/demo_users_dataset (assuming you are using the demo_resources
  • Should see the fields in this dataset's collection
  • Can also load another collection into the same dataset via fidesctl apply to use the dropdown to choose a different collection

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

I pulled out the "Be able to navigate to collections" step to #712. So right now you'll just have to type the proper fideskey into the URL to get to this path, since there isn't an interaction to get there yet.

Screen.Recording.2022-05-26.at.10.44.34.AM.mov

Also, this doesn't have tests yet. The components themselves are pretty simple (just tables and such), so I don't think unit tests would be the best for this case. It's more the flow of data that is more complicated, and so I think this would most benefit from Cypress tests. Cypress is still being set up, but once that's in we can add a whole bunch of more thorough tests, ticket: #713

@allisonking allisonking marked this pull request as ready for review May 26, 2022 15:03
@allisonking allisonking requested a review from a team May 26, 2022 15:03
Copy link
Contributor

@LKCSmith LKCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start 🎉 Left a couple of Q's

@LKCSmith LKCSmith self-requested a review May 31, 2022 17:34
@allisonking allisonking merged commit 2b15040 into main May 31, 2022
@allisonking allisonking deleted the aking-700-dataset-detail branch May 31, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants