Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mount location for dev privacy center #3063

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Fix mount location for dev privacy center #3063

merged 1 commit into from
Apr 13, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Apr 13, 2023

Code Changes

  • Fix mount location for dev privacy center config.json to mount the sample project config

Steps to Confirm

  • Run nox -s quickstart to fully exercise the dev environment setup

Pre-Merge Checklist

Description Of Changes

This is a regression for the development environment introduced by #3017. Obvious mistake is obvious!

@cypress
Copy link

cypress bot commented Apr 13, 2023

Passing run #1330 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 382bd48 into 177ad01...
Project: fides Commit: 6b408b1333 ℹ️
Status: Passed Duration: 00:38 💡
Started: Apr 13, 2023 1:21 AM Ended: Apr 13, 2023 1:22 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (177ad01) 87.41% compared to head (382bd48) 87.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3063   +/-   ##
=======================================
  Coverage   87.41%   87.41%           
=======================================
  Files         306      306           
  Lines       17540    17540           
  Branches     2255     2255           
=======================================
  Hits        15333    15333           
  Misses       1793     1793           
  Partials      414      414           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NevilleS NevilleS marked this pull request as ready for review April 13, 2023 11:58
@NevilleS NevilleS merged commit 8558b80 into main Apr 13, 2023
@NevilleS NevilleS deleted the ns-fix-quickstart branch April 13, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant