Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aircall Connector #2589

Merged
merged 21 commits into from
Apr 17, 2023
Merged

Aircall Connector #2589

merged 21 commits into from
Apr 17, 2023

Conversation

tmuralikrishnan
Copy link
Contributor

@tmuralikrishnan tmuralikrishnan commented Feb 14, 2023

Closes #1297

Code Changes

NEW SaaS Connector Aircall for access

Steps to Confirm

  • Add/configure the Aircall connector in UI
  • Verify Aircall config and icon UI looks good
  • Add customer data using UI
  • Add calls data using Aircall App(no api for create calls)
  • Create an Access DSR with the new Aircall customer phone number
  • Verify email sent by fides with customer data is correct
  • Create an Delete DSR with the new Aircall customer phone number
  • Verify the customer data is now deleted in Aircall

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

SaaS Connector Checklist

  • Spec doc link
  • Vault Creds
  • Postman Collection
  • SaaS Config And Dataset
  • Access and Erasure Test Passing
  • Icon

@cypress
Copy link

cypress bot commented Feb 14, 2023

Passing run #1326 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c7854df into 177ad01...
Project: fides Commit: 8d967722da ℹ️
Status: Passed Duration: 00:53 💡
Started: Apr 12, 2023 11:56 PM Ended: Apr 12, 2023 11:57 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (4a864b2) 87.39% compared to head (c7854df) 87.41%.

❗ Current head c7854df differs from pull request most recent head 724d2b6. Consider uploading reports for the commit 724d2b6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2589      +/-   ##
==========================================
+ Coverage   87.39%   87.41%   +0.02%     
==========================================
  Files         306      306              
  Lines       17598    17540      -58     
  Branches     2270     2255      -15     
==========================================
- Hits        15379    15333      -46     
+ Misses       1801     1793       -8     
+ Partials      418      414       -4     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmuralikrishnan
Copy link
Contributor Author

image

@tmuralikrishnan
Copy link
Contributor Author

image

@tmuralikrishnan
Copy link
Contributor Author

image

@tmuralikrishnan tmuralikrishnan changed the title aircall access and erasure request aircall access request Mar 2, 2023
@tmuralikrishnan tmuralikrishnan changed the title aircall access request aircall access and erasure request Mar 9, 2023
@tmuralikrishnan
Copy link
Contributor Author

In user privacy request creation page phone number is required and email is optional for aircall.

@Kelsey-Ethyca Kelsey-Ethyca changed the title aircall access and erasure request Aircall Connector Mar 13, 2023
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good but we need to update the authentication strategy to basic. Also be mindful of not making changes to code that is not related to this connector (like fides.toml and the privacy center config) and leaving commented code

@galvana galvana merged commit a0ab9b7 into main Apr 17, 2023
@galvana galvana deleted the aircall-access-muralikrishnan branch April 17, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aircall
4 participants