-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aircall Connector #2589
Aircall Connector #2589
Conversation
Passing run #1326 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2589 +/- ##
==========================================
+ Coverage 87.39% 87.41% +0.02%
==========================================
Files 306 306
Lines 17598 17540 -58
Branches 2270 2255 -15
==========================================
- Hits 15379 15333 -46
+ Misses 1801 1793 -8
+ Partials 418 414 -4 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
In user privacy request creation page phone number is required and email is optional for aircall. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good but we need to update the authentication strategy to basic
. Also be mindful of not making changes to code that is not related to this connector (like fides.toml and the privacy center config) and leaving commented code
Closes #1297
Code Changes
NEW SaaS Connector Aircall for access
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
SaaS Connector Checklist