Restrict startsWith comparisons in CheckboxTree more #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix a bug where checking user.biometric would also check user.biometric_health
allisonking
force-pushed
the
aking-fix-checkbox-tree-bug
branch
from
cfb6f7f to
3c938fa
Compare
ssangervasi
added a commit
that referenced
this pull request
Oct 1, 2022
* main: Restrict startsWith comparisons in CheckboxTree more (#1126) [1076] ui/plus: Approve dataset classification button (#1129) Do not rely on order for checking intercept results (#1131) Prepare 1.9.1 release (#1137) Bump fideslang to 1.3.1 (#1136) Prepare changelog for 1.9.0 release (#1134) Update CHANGELOG.md (#1132) Fix bug causing missing datamap rows (#1124) cls migration (#1060)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on taxonomy dropdowns, I found a small 🐛 where checking
user.biometricwould also checkuser.biometric_healtheven though they are siblings to each other. This was because of some scrappystartsWithcomparisons we were doing. This PR firms up that comparison so it is a little more sophisticated.Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdDescription Of Changes
Before:
Screen.Recording.2022-09-27.at.4.45.51.PM.mov
After:
Screen.Recording.2022-09-27.at.4.44.45.PM.mov