Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package name for unified fides #1015

Merged
merged 16 commits into from
Aug 24, 2022

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Aug 24, 2022

Closes #1014

Code Changes

  • update setup.py references to fidesctl, renaming the package to ethyca-fides
  • update the entrypoint to only be fides
  • update the directory name

Steps to Confirm

  • pip install locally and play around with it

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

This PR sets the proverbial packaging stage for a unified fides by updating the package name from fidesctl as well as the entry points and all specific code references to fidesctl

@ThomasLaPiana ThomasLaPiana self-assigned this Aug 24, 2022
@ThomasLaPiana ThomasLaPiana changed the title Update setup.py Update package name for unified fides Aug 24, 2022
@ThomasLaPiana
Copy link
Contributor Author

these are the 4 checks that are expected to fail, shipping it

@ThomasLaPiana ThomasLaPiana marked this pull request as ready for review August 24, 2022 07:17
@ThomasLaPiana ThomasLaPiana requested review from a team August 24, 2022 07:17
@ThomasLaPiana ThomasLaPiana merged commit 7e70741 into unified-fides Aug 24, 2022
@ThomasLaPiana ThomasLaPiana deleted the ThomasLaPiana-rename-fides-package branch August 24, 2022 07:18
@sanders41
Copy link
Contributor

sanders41 commented Aug 24, 2022

Since users will need to install with pip install ethyca-fides now it would be good to do one more pypi release to fidesctl explaining the change and include a setup.py that has ethyca-fides it's requirement. That way if someone already has fidesctl as a dependency they will get the new one instead of the last release of fidesctl thinking they are getting the latest.

@ThomasLaPiana
Copy link
Contributor Author

@sanders41 for sure, we release fidesctl at the end of every sprint now so I assume we'll have at least two more releases :)

This will also be included as part of the docs overhaul, and we can (and will) add a deprecation notice to the fides CLI for the last version so anyone still using fidesctl will be made aware of the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the setup.py package info to rename the package to ethyca-fides
2 participants