Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CLI command to tell users when they haven't annotated something #1173

Closed
ThomasLaPiana opened this issue Oct 3, 2022 · 6 comments
Closed
Assignees

Comments

@ThomasLaPiana
Copy link
Contributor

ThomasLaPiana commented Oct 3, 2022

Is your feature request related to a specific problem?

I can not add data categories or qualifiers to a dataset and nothing yells at me/warns me

Describe the solution you'd like

We should add stricter checking possibly by default or via flag to one of our commands...potentially fides parse --strict ?

Describe alternatives you've considered, if any

Adding an entirely separate command feels like too much, maybe we would only add it to the evaluation flow?

Additional context

This would make annotating a huge dataset file so much easier...being able to pinpoint exactly what needs annotation and not letting potentially dangerous use-cases slip through

@ThomasLaPiana
Copy link
Contributor Author

@mfbrown @NevilleS any opinions here from a product standpoint? On multiple occasions we've noticed that the lack of strict checking, specifically at parse/push time has come to bite us, and will therefore surely bite our customers

I'm thinking making fides parse do this by default is also a viable alternative to fides parse --strict, and instead give users the escape hatch of fides parse --no-strict or something

wiseaidev pushed a commit to wiseaidev/fides that referenced this issue Oct 4, 2022
@rsilvery
Copy link
Contributor

Would this fit better as a Q4FidesCls Enhancements @mfbrown ?

@ThomasLaPiana
Copy link
Contributor Author

I don't think this is fidescls related specifically, it affects fides as well

@rsilvery
Copy link
Contributor

@ThomasLaPiana , @seanpreston can you help me understand this function? How does this compare to our UI implementation?

@rsilvery
Copy link
Contributor

@ThomasLaPiana we're rethinking this whole flow right now. We're going to bench this ticket in the meanwhile unless you think it's urgent right now.

@ThomasLaPiana
Copy link
Contributor Author

@rsilvery this is related to the CLI-flow, not the UI flow (if that was in question)

What was happening here is that I was working on annotating a dataset, and it would parse without issue, but then it would false the fides scan command because I had left out data categories. I wish I could have known without running the scan command that I was missing certain fields, hence the potential for some kind of --strict command which we use elsewhere sometimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants