-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CLI command to tell users when they haven't annotated something #1173
Comments
@mfbrown @NevilleS any opinions here from a product standpoint? On multiple occasions we've noticed that the lack of strict checking, specifically at parse/push time has come to bite us, and will therefore surely bite our customers I'm thinking making |
…1173) Co-authored-by: Dawn Pattison <[email protected]>
Would this fit better as a Q4FidesCls Enhancements @mfbrown ? |
I don't think this is |
@ThomasLaPiana , @seanpreston can you help me understand this function? How does this compare to our UI implementation? |
@ThomasLaPiana we're rethinking this whole flow right now. We're going to bench this ticket in the meanwhile unless you think it's urgent right now. |
@rsilvery this is related to the CLI-flow, not the UI flow (if that was in question) What was happening here is that I was working on annotating a dataset, and it would parse without issue, but then it would false the |
Is your feature request related to a specific problem?
I can not add data categories or qualifiers to a dataset and nothing yells at me/warns me
Describe the solution you'd like
We should add stricter checking possibly by default or via flag to one of our commands...potentially
fides parse --strict
?Describe alternatives you've considered, if any
Adding an entirely separate command feels like too much, maybe we would only add it to the
evaluation
flow?Additional context
This would make annotating a huge dataset file so much easier...being able to pinpoint exactly what needs annotation and not letting potentially dangerous use-cases slip through
The text was updated successfully, but these errors were encountered: