Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cannon): Use consistent fork type #419

Merged
merged 3 commits into from
Dec 2, 2024
Merged

fix(cannon): Use consistent fork type #419

merged 3 commits into from
Dec 2, 2024

Conversation

samcm
Copy link
Member

@samcm samcm commented Dec 2, 2024 •
edited
Loading

Fix for this one in cannon, which is a casing issue

time="2024-12-02T05:42:47Z" level=error msg="unknown activation fork: BELLATRIX" error="no fork at epoch"

@samcm samcm requested a review from Savid as a code owner December 2, 2024 05:55
mattevans
mattevans approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@mattevans mattevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find

@samcm
Copy link
Member Author

samcm commented Dec 2, 2024

good find

cheers (im pretty sure i just broke it with that ethpandaops/beacon version bump 😆)

@samcm samcm merged commit d4847e4 into master Dec 2, 2024
4 of 5 checks passed
@samcm samcm deleted the fix/cannon-fork-names branch December 2, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattevans mattevans mattevans approved these changes

@Savid Savid Awaiting requested review from Savid Savid is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samcm @mattevans