Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update field name 'Transient' to 'Limited' #417

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

mattevans
Copy link
Member

@mattevans mattevans commented Dec 2, 2024

The following commit upstream (probe-lab/hermes@614e34e September 2024) stopped CONNECTED/DISCONNECTED host events from being parsed correctly in Xatu. Gone unnoticed until now, as we were previously using a fork of Hermes until #410

This PR updates our expected event payload message to conform to what we're receiving.

Screenshot 2024-12-02 at 12 30 56

@mattevans mattevans self-assigned this Dec 2, 2024
@mattevans mattevans marked this pull request as ready for review December 2, 2024 02:33
@mattevans mattevans requested a review from Savid as a code owner December 2, 2024 02:33
@mattevans mattevans merged commit dedce7f into master Dec 2, 2024
4 of 5 checks passed
@mattevans mattevans deleted the fix/hermes-host-event-payload-changes branch December 2, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants