Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(xatu): allow setting metrics addr via cli flag #414

Merged
merged 9 commits into from
Dec 2, 2024

Conversation

mattevans
Copy link
Member

@mattevans mattevans commented Dec 2, 2024

Allows setting --metrics-addr=:XXXX via cli flag for the following Xatu pkgs...

  • cannon
  • cl-mimicry
  • discovery
  • mimicry
  • relay-monitor
  • sentry
  • server

Takes precedence over any metricsAddr set in config.

Example (without flag)
go run main.go sentry                                                                                                                                                            
...
INFO[0000] Serving metrics at :9090                      module=sentry
Example (with flag)
go run main.go sentry --metrics-addr=:8765                                                                                                                                                            
...
INFO[0000] Overriding metrics address                    address=":8765" module=sentry
INFO[0000] Serving metrics at :8765                      module=sentry

@mattevans mattevans self-assigned this Dec 2, 2024
@mattevans mattevans marked this pull request as ready for review December 2, 2024 00:22
@mattevans mattevans requested a review from Savid as a code owner December 2, 2024 00:22
@mattevans mattevans merged commit e9ee15b into master Dec 2, 2024
3 of 5 checks passed
@mattevans mattevans deleted the refactor/cli-arg-metrics-addr branch December 2, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants