Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getExchangeOffers endpoint #111

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Add getExchangeOffers endpoint #111

merged 3 commits into from
Apr 10, 2024

Conversation

kaushalrajbacancy
Copy link
Contributor

@kaushalrajbacancy kaushalrajbacancy commented Apr 1, 2024 •
edited
Loading

Description

  • Added getExchangeOffers endpoint
  • The type name UserOpsTransaction has been changed to UserOpTransaction
  • Exported UserOpTransaction from module

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

- It has been tested locally.

image

ch4r10t33r
ch4r10t33r requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a breaking change? You are changing the return type and structure? Please change it accordingly.

package.json Outdated Show resolved Hide resolved
ch4r10t33r
ch4r10t33r approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kaushalrajbacancy kaushalrajbacancy merged commit 405cd0c into master Apr 10, 2024
6 checks passed
@kaushalrajbacancy kaushalrajbacancy deleted the add-getexchangeoffers-endpoint branch April 10, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@vignesha22 vignesha22 vignesha22 approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

@lbw33 lbw33 Awaiting requested review from lbw33

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaushalrajbacancy @ch4r10t33r @vignesha22