Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change type of formats.receipt.root hash -> hex #952

Closed
wants to merge 4 commits into from
Closed

fix: change type of formats.receipt.root hash -> hex #952

wants to merge 4 commits into from

Commits on Jul 14, 2020

  1. fix: change type of formats.receipt.root hash -> hex 

    - Currently formatter expects a transaction receipt's root property to be a hash, so 32 bytes
- However, that does not match definition used in geth,
  where this maps to the PostState fields within the Receipt struct,
  thus the current validation appears to be based on convention
- This is currently causing issue with transactions submitted to
  a non-Ethereum, but EVM and JSON-RPC compliant, network
- Refs:
  - https://github.com/ethereum/go-ethereum/blob/ce9a289/core/types/receipt.go#L49-L52
  - NomicFoundation/hardhat#694 (comment)
    @bguiz
    bguiz committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    e1fc2a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. test: add test cases for formatter class

    @bguiz
    bguiz committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    f134e48 View commit details
    Browse the repository at this point in the history

  2. fix: update reason to say 'invalid hex' instead of 'invalid hash' wit… 

    …hin the formatter.hex validator
    @bguiz
    bguiz committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    28843b1 View commit details
    Browse the repository at this point in the history

  3. chore: tsc build output

    @bguiz
    bguiz committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    435fd4d View commit details
    Browse the repository at this point in the history