v5 ContractFactory.deploy() ignores transaction overrides

[pyggie]

In ethers-v5 a deployment transaction such as factory.deploy({ gasPrice, gasLimit }) ignores the transaction overrides. I think the problem is in resolveAddresses() called from here:

ethers.js/packages/contracts/src.ts/index.ts

Lines 982 to 983 in db604aa

	deploy(...args: Array<any>): Promise<Contract> {
	return resolveAddresses(this.signer, args, this.interface.deploy.inputs).then((args) => {

ethers.js/packages/contracts/src.ts/index.ts

Lines 84 to 91 in db604aa

	function resolveAddresses(signerOrProvider: Signer | Provider, value: any, paramType: ParamType | Array<ParamType>): Promise<any> {
	if (Array.isArray(paramType)) {
	return Promise.all(paramType.map((paramType, index) => {
	return resolveAddresses(
	signerOrProvider,
	((Array.isArray(value)) ? value[index]: value[paramType.name]),
	paramType
	);

which maps on paramType = this.interface.deploy.inputs = [] and so returns nothing.

[ricmoo]

I’ll look into this shortly. Thanks!

[ricmoo]

I've reproduced it and am re-factoring a bit of that code now which should address this issue and clean things up a bit.

[ricmoo]

This should be fixed in 5.0.0-beta.183. Try it out and let me know. :)

[pyggie]

It works!

[ricmoo]

Awesome! :)