-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: no matching event (argument="topichash" #733
Comments
Actually, maybe it should still try to decode the event and simply return null. That way, we can easily support such event by adding the event to the contract ABI. |
Exactly my thoughts. Thanks for the PR. I’ll get to it today. :) |
This has been published in the latest version. Give it a go and let me know if you have any problems. :) |
I'm going to close this now. If you have any issues, please feel free to reopen. Thanks! :) |
There seems to be an issue in latest ethers.js v5. It looks like it try to parse event from the log even if these come from contract down the chain (and not from the contract whose abi is known)
Looking at the code I guess it should filter out log that originate from a different address than the contract address :
ethers.js/src.ts/contract.ts
Line 278 in 2987925
But it would be cool if we could somehow set address to abi mapping in ethers so ethers could parse these automatically
The text was updated successfully, but these errors were encountered: