-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: switch to async/await from nested promises in code #634
Comments
I'll be making these changes soon, along with switching a large number of The original reason for not doing this was that I was targeting ES3, but since it is all in TypeScript now, it can easily handle all that during compilation. :) |
Thank you very much! |
@ricmoo That’s great news!! |
Much of the codebase has now been migrated, and when I notice little areas here and there that could benefit from this I'm updating them. I'm going to close this now, but please feel free to re-open or if you notice somewhere that could benefit, add a comment to this issue. Thanks! :) |
Hi:
I noticed that there are places where the promise chain is nested, would you mind if I do a PR for BaseProvider and others to switch them to async/await (for methods that return Promise)?
Or, is there a reason for not using async/await at the moment?
If that's the case, flattening promises would be good too.
Thanks!
The text was updated successfully, but these errors were encountered: