Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mnemonic backup phrases should be case agnostic #557

Closed
ricmoo opened this issue Jul 9, 2019 · 2 comments
Closed

Mnemonic backup phrases should be case agnostic #557

ricmoo opened this issue Jul 9, 2019 · 2 comments
Assignees
@ricmoo
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@ricmoo
Copy link
Member

ricmoo commented Jul 9, 2019

I have recently found that depending on the code path used to generate a Wallet from a mnemonic, the case of the mnemonic may matter, which it should not.

This is a high priority issue and will be fixed in both v4 and v5 immediately.
@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. labels Jul 9, 2019
@ricmoo ricmoo self-assigned this Jul 9, 2019
ricmoo added a commit that referenced this issue Jul 9, 2019
@ricmoo
Make mnemonics case-agnostic (#557).
ef91dcd
ricmoo added a commit that referenced this issue Jul 9, 2019
@ricmoo
Added test cases for case-agnostic mnemonics (#557).
a34ca6b
@ricmoo
Copy link
Member Author

ricmoo commented Jul 9, 2019

(note the above two commits are "unverified"; this is a new laptop, and there was a configuration error in how I setup the GPG tools' e-mail address, it will be fixed shortly for future commits)

ricmoo added a commit that referenced this issue Jul 9, 2019
@ricmoo
Make mnemonic phrases case agnostic (#557).
e4423b7
@ricmoo ricmoo removed the on-deck This Enhancement or Bug is currently being worked on. label Jul 10, 2019
@ricmoo
Copy link
Member Author

ricmoo commented Jul 10, 2019

This has been fixed in the v4 version 4.0.33 and the v5 5.0.0-beta.144.

If you require the legacy behaviour, please install a major version prior to these minor versions.

And if anyone is having issues, please feel free to re-open this ticket.

Thanks! :)

@ricmoo ricmoo closed this as completed Jul 10, 2019
@ricmoo ricmoo added the fixed/complete This Bug is fixed or Enhancement is complete and published. label Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricmoo