-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid Address Error #532
Comments
Eek! You're correct; this is a bug in the v5 beta branch. I'll fix this right away. |
This should be fixed in the latest version. Please make sure you remove the Let me know if you have any problems. :) |
Closing now, but feel free to re-open if you continue having issues. Also, I monitor closed issues. Thanks! :) |
Sorry forgot to reply here! Yes fix looks all good. Thanks mate! |
When using the
JsonRpcSigner
without providing aaddressOrIndex
an error is thrown. If no value is passed in, theaddressOrIndex
is reassigned to0
. ThenaddressOrIndex
is evaluated as to whether it is "truthy" in thisif
block:ethers.js/packages/providers/src.ts/json-rpc-provider.ts
Line 63 in 9122310
Due to JavaScript coercion,
0
evaluates to a "falsey" value and the_index
property is never assigned in this line:ethers.js/packages/providers/src.ts/json-rpc-provider.ts
Line 68 in 9122310
The text was updated successfully, but these errors were encountered: