Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new Contract() complains if address is an Addressable type #4538

Closed
yuetloo opened this issue Jan 11, 2024 · 1 comment
Closed

new Contract() complains if address is an Addressable type #4538

yuetloo opened this issue Jan 11, 2024 · 1 comment
Assignees
@ricmoo
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6

Comments

@yuetloo
Copy link
Collaborator

yuetloo commented Jan 11, 2024

Ethers Version

6.9.2

Search Terms

contract

Describe the Problem

const factory = new ContractFactory(...)
const contract = await factory.deploy()
const anotherContract = new Contract(contract.target, abi, wallet) ==> should not complain contract.target is not a string.

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

No response

Environment (Other)

No response
@yuetloo yuetloo added investigate Under investigation and may be a bug. v6 Issues regarding v6 labels Jan 11, 2024
@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. minor-bump Planned for the next minor version bump. next-patch Issues scheduled for the next arch release. and removed investigate Under investigation and may be a bug. labels Jan 13, 2024
ricmoo added a commit that referenced this issue Feb 2, 2024
@ricmoo
Expand Contract sub-class to accept BaseContract super-class construc…
98496bc 
…tor arguments (#4538).
@ricmoo
Copy link
Member

ricmoo commented Feb 9, 2024

This has been added in v6.11.0.

Thanks! :)

@ricmoo ricmoo closed this as completed Feb 9, 2024
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. next-patch Issues scheduled for the next arch release. labels Feb 9, 2024
@snyk-io snyk-io bot mentioned this issue May 21, 2024
Open
This was referenced May 22, 2024
Open
Open
@kalbroni7 kalbroni7 mentioned this issue Jun 6, 2024
Open
@Mapuppy09 Mapuppy09 mentioned this issue Jun 12, 2024
Merged
This was referenced Jun 20, 2024
Open
Open
This was referenced Jun 23, 2024
Open
Open
@swirlds-automation swirlds-automation mentioned this issue Jun 26, 2024
Merged
@X-oss-byte X-oss-byte mentioned this issue Jul 9, 2024
Open
@sea-edge sea-edge mentioned this issue Aug 10, 2024
Open
@X-oss-byte X-oss-byte mentioned this issue Aug 16, 2024
Open
This was referenced Sep 10, 2024
Closed
Merged
@omkar-121 omkar-121 mentioned this issue Oct 2, 2024
Open
@X-oss-byte X-oss-byte mentioned this issue Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump. v6 Issues regarding v6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @yuetloo