6.4.0 breaks dynamic import from some CDNs

[ardislu]

Ethers Version

6.4.0

Search Terms

cdn, 6.4.0, jsdelivr

Describe the Problem

Steps to reproduce the issue:

1. Open DevTools in a web browser.
2. Dynamically import ethers v6.4.0 from the jsdelivr CDN:

const ethers = await import('https://cdn.jsdelivr.net/npm/[email protected]/+esm');

Expected result: ethers is imported successfully.

Actual result: the import fails when trying to import the ens-normalize dependency:

GET https://cdn.jsdelivr.net/npm/@adraffy/ens-normalize@git%2Bhttps%3A%2F%2Fgithub.com%2Fricmoo%2Fens-normalize.js.git/+esm net::ERR_ABORTED 404

Workaround:

• Importing 6.3.0 works as expected:

const ethers = await import('https://cdn.jsdelivr.net/npm/[email protected]/+esm');

• Importing from a different CDN, such as cdnjs, works as expected:

const ethers = await import('https://cdnjs.cloudflare.com/ajax/libs/ethers/6.4.0/ethers.js');

---

I believe the root cause is in 7e272a3, where package.json was updated like so:

   "dependencies": {
-    "@adraffy/ens-normalize": "1.9.0",
+    "@adraffy/ens-normalize": "https://github.com/ricmoo/ens-normalize.js",
     "@noble/hashes": "1.1.2",

Since other CDNs handle this dependency correctly, it may just be an issue with jsdelivr and nothing to do with ethers. Nonetheless, thought others may want to know in case they encounter this very specific edge case.

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

Browser (Chrome, Safari, etc)

Environment (Other)

No response

[ardislu]

This is very similar to #4071 but in a different context. Not sure if this deserves its own issue, feel free to close this issue if it's redundant.

[ricmoo]

Hmmm. The CDN should be pulling in the file from the dist/?

But I’ll get these upstream changes submitted tomorrow so I can switch back to using the official package…

[pablomendezroyo]

Same issue here

[dsimog01]

Same issue when using npx:

npm verb exit 1
npm verb unfinished npm timer reify 1684840339473
npm verb unfinished npm timer reify:unpack 1684840341873
npm verb unfinished npm timer reifyNode:node_modules/@adraffy/ens-normalize 1684840341880
npm verb code 1

[ricmoo]

This is the same issue as #4071, I'll be keeping that issue updated instead of this one. :)

[ricmoo]

This should be fixed in v6.4.2. Can you try it out and let me know if you still have any problems?

[ardislu]

Thank you for the update!

I just tried this:

const ethers = await import('https://cdn.jsdelivr.net/npm/[email protected]/+esm');

And looks like it's working now. Thanks!

[ricmoo]

Awesome! Glad to hear it! Thanks. :)