Problem with nonce increment in NonceManager

[adetante]

Describe the Feature

I think there is a problem with the NonceManager.getNonce function in v6, which causes a general increment of the nonce:

async sendTransaction(tx: TransactionRequest): Promise<TransactionResponse> {
  const noncePromise = this.getNonce("pending");
  this.increment();

  tx = await this.signer.populateTransaction(tx);
  tx.nonce = await noncePromise; // nonce has already been incremented!

  // ...
}

async getNonce(blockTag?: BlockTag): Promise<number> {
  if (blockTag === "pending") {
     if (this.#noncePromise == null) {
       this.#noncePromise = super.getNonce("pending");
      }
      return (await this.#noncePromise) + this.#delta;
    }

    return super.getNonce(blockTag);
}

increment(): void {
  this.#delta++;
}

v5 used a temporary variable captured in the lambda: https://github.com/ethers-io/ethers.js/blob/v5.7.2/packages/experimental/src.ts/nonce-manager.ts#L34

Code Example

No response

[adetante]

Here is my PR: #3813

[ricmoo]

Should be fixed in v6.0.6. Try it out and let me know.

Thanks! :)