fromEncryptedWallet Errors if PW Longer then 64 bytes

[NoahMarconi]

It's an issue with the dependent libraries, you're using a typed array and they expect an array with push.

Locally I fixed by editing this line

ethers.js/wallet/secret-storage.js

Line 230 in 564c5fa

scrypt(password, salt, N, r, p, 64, function(error, progress, key) {

to:

                scrypt(Array.from(password), salt, N, r, p, 64, function(error, progress, key) {

I see these are both your repos so not sure if you want the fix here or in the scrypt-js repo. Here's where the error occurs if you pass in a typed array:

https://github.com/ricmoo/scrypt-js/blob/master/scrypt.js#L90

[ricmoo]

Ah yes. I have an open issue in scrypt-js I believe for this too. I will fix it there. I also want to move to using promises in that library, so I’ll update that too.

Thanks! I should be able to get to this very soon.

[ricmoo]

This has been fixed in the dependency and the latest version has been updated in the package.json and dist files.

Let me know if there are any problems.

Thanks! :)