Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Id function not defined #2115

Closed
fulldecent opened this issue Sep 29, 2021 · 3 comments
Closed

Id function not defined #2115

fulldecent opened this issue Sep 29, 2021 · 3 comments
Labels
documentation Documentation related issue.

Comments

@fulldecent
Copy link

On the page https://github.com/ethers-io/ethers.js/blob/ce8f1e4015c0f27bf178238770b1325136e3351a/docs/v5/concepts/events/README.md

The function id is used but not defined.
@fulldecent fulldecent added the investigate Under investigation and may be a bug. label Sep 29, 2021
@zemse
Copy link
Collaborator

zemse commented Sep 29, 2021

That is the ethers.utils.id method. I agree including import statement or using utils.id would help

@ricmoo ricmoo added documentation Documentation related issue. and removed investigate Under investigation and may be a bug. labels Oct 16, 2021
@ricmoo
Copy link
Member

ricmoo commented Feb 3, 2022

In general, especially for concepts, I'd prefer keeping things as concise as possible, but for now I will use utils.id.

ricmoo added a commit that referenced this issue Feb 3, 2022
@ricmoo
docs: more explicitly describe the id function (#2115).
1d419b5
@ricmoo
Copy link
Member

ricmoo commented Feb 3, 2022

Merged.

Thanks! :)

@ricmoo ricmoo closed this as completed Feb 3, 2022
This was referenced Apr 12, 2022
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation related issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fulldecent @ricmoo @zemse