Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would be nice: HDNode.derivePath => publicKey / privateKey and address (checksum) #196

Closed
SilentCicero opened this issue Jun 11, 2018 · 2 comments
Closed

Would be nice: HDNode.derivePath => publicKey / privateKey and address (checksum) #196

SilentCicero opened this issue Jun 11, 2018 · 2 comments
Assignees
@ricmoo
Labels
enhancement New feature or improvement.

Comments

@SilentCicero
Copy link

SilentCicero commented Jun 11, 2018 •
edited
Loading

Feature request!

For ease of use, it would be nice if the HDNode.derivePath method would return an object with publicKey / privateKey and the address in checksum format (currently only privateKey / publicKey + extras). I know I can just derive the address, but it's an extra step. Might as well give the whole taco here.

Thanks!
@SilentCicero SilentCicero changed the title Would be nice: HDNode.derive => publicKey / privateKey and address (checksum) Would be nice: HDNode.derivePath => publicKey / privateKey and address (checksum) Jun 11, 2018
@ricmoo
Copy link
Member

ricmoo commented Jun 14, 2018

This seems totally reasonable. :)

@ricmoo ricmoo added the enhancement New feature or improvement. label Jun 14, 2018
@ricmoo ricmoo self-assigned this Jun 14, 2018
@ricmoo ricmoo added v4.0 and removed enhancement New feature or improvement. labels Jun 29, 2018
@ricmoo ricmoo added enhancement New feature or improvement. and removed v4.0 labels Sep 30, 2018
ricmoo added a commit that referenced this issue Oct 7, 2018
@ricmoo
Added address to HDNode (#196).
e39e2ed
@ricmoo
Copy link
Member

ricmoo commented Oct 7, 2018

Added to [email protected].

Thanks! :)

@ricmoo ricmoo closed this as completed Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
enhancement New feature or improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @SilentCicero