FixedNumber.round() throws incompatible format on non-default formats

[zedkai]

Describe the bug
Rounding numbers which are not of the default format results in an incompatible format error.

Reproduction steps

FixedNumber.fromValue(1, 27, "fixed256x27").round()

Error produced:

Uncaught Error: incompatible format; use fixedNumber.toFormat (argument="other", value={"format":{"signed":true,"width":128,"decimals":18,"name":"fixed128x18","_multiplier":"1000000000000000000"},"_hex":"0x0de0b6b3a7640000","_value":"1.0","_isFixedNumber":true}, code=INVALID_ARGUMENT, version=bignumber/5.1.1)
  makeError index.ts:205
  throwError index.ts:217
  throwArgumentError index.ts:221
  _checkFormat fixednumber.ts:211
  mulUnsafe fixednumber.ts:230
  round fixednumber.ts:283
  <anonymous> debugger eval code:1

Environment:
Browser JS context.

Search Terms
FixedNumber, round, rounding

[ricmoo]

Thanks! That looks like a bug on my side. I’ll look into this shortly.

[ricmoo]

This should be fixed in 5.3.0. Try it out and let me know if you still have any issues.

Thanks! :)

[alexanderwende]

Hi, I think there's still a small bug in there, when working with negative numbers...

Describe the bug

Rounding negative numbers which are not of the default format results in an incompatible format error.

Reproduction steps

FixedNumber.from('-0.01101100205516751', 'fixed128x17').round(2)

Error produced

Uncaught Error: incompatible format; use fixedNumber.toFormat (argument="other", value={"format":{"signed":true,"width":128,"decimals":18,"name":"fixed128x18","_multiplier":"1000000000000000000"},"_hex":"0x0de0b6b3a7640000","_value":"1.0","_isFixedNumber":true}, code=INVALID_ARGUMENT, version=bignumber/5.4.0)
    at Logger.makeError (index.ts:213)
    at Logger.throwError (index.ts:225)
    at Logger.throwArgumentError (index.ts:229)
    at FixedNumber._checkFormat (fixednumber.ts:217)
    at FixedNumber.subUnsafe (fixednumber.ts:229)
    at FixedNumber.floor (fixednumber.ts:257)
    at FixedNumber.round (fixednumber.ts:294)

Environment

browser

Notes

When removing the minus sign from the number, no error is thrown.