Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bigint to BigNumberish in next minor version bump #1472

Closed
ricmoo opened this issue Apr 15, 2021 · 1 comment
Closed

Add bigint to BigNumberish in next minor version bump #1472

ricmoo opened this issue Apr 15, 2021 · 1 comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump.

Comments

@ricmoo
Copy link
Member

ricmoo commented Apr 15, 2021

Right now the type definition is export type BigNumberish = BigNumber | Bytes | string | number;, but it seems BigInt's are supported anywhere BigNumber is supported, so perhaps this should be export type BigNumberish = BigNumber | Bytes | string | number | bigint;

Currently trying to pass a BigInt when BigNumberish is expected gives Argument of type 'bigint' is not assignable to parameter of type 'BigNumberish'. ts(2345)

Originally posted by @mds1 in #1471
@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. minor-bump Planned for the next minor version bump. labels Apr 15, 2021
ricmoo added a commit that referenced this issue May 14, 2021
@ricmoo
Add bigint to allowed BigNumberish types (#1472).
cadccc3
ricmoo added a commit that referenced this issue May 14, 2021
@ricmoo
Added hex support for bigint (#1472).
4e9abfd
@ricmoo
Copy link
Member Author

ricmoo commented May 20, 2021

This has been added in 5.2.0.

Thy it out and let me know if there are any issues.

Thanks! :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels May 20, 2021
@ricmoo ricmoo closed this as completed May 30, 2021
pull bot pushed a commit to shapeshift/ethers.js that referenced this issue Jun 4, 2021
@ricmoo @pull
Add bigint to allowed BigNumberish types (ethers-io#1472).
03c1869
pull bot pushed a commit to shapeshift/ethers.js that referenced this issue Jun 4, 2021
@ricmoo @pull
Added hex support for bigint (ethers-io#1472).
57e1648
pull bot pushed a commit to shapeshift/ethers.js that referenced this issue Jun 4, 2021
@ricmoo @pull
Add bigint to allowed BigNumberish types (ethers-io#1472).
4f768b5
pull bot pushed a commit to shapeshift/ethers.js that referenced this issue Jun 4, 2021
@ricmoo @pull
Added hex support for bigint (ethers-io#1472).
d4ecc32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. minor-bump Planned for the next minor version bump.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricmoo