Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconfigured ENS names cause a tx to becomes an init tx #1290

Closed
ricmoo opened this issue Feb 12, 2021 · 1 comment
Closed

Unconfigured ENS names cause a tx to becomes an init tx #1290

ricmoo opened this issue Feb 12, 2021 · 1 comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@ricmoo
Copy link
Member

ricmoo commented Feb 12, 2021

When sending a transaction, if an ENS is given that resolves to null, the transaction becomes a contract creation transaction (i.e. no to address), but the transaction should fail.

Reported and reproduction steps provided by @yuetloo.
@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. labels Feb 12, 2021
@ricmoo ricmoo changed the title In Signer.sendTransaction unconfigured ENS names resolve to null Unconfigured ENS names cause a tx to becomes an init tx Feb 12, 2021
ricmoo added a commit that referenced this issue Feb 13, 2021
@ricmoo
Prevent unconfigured ENS names from making an init tx (#1290).
243beff
@ricmoo
Copy link
Member Author

ricmoo commented Feb 13, 2021

This should be fixed in 5.0.31.

Thanks @yuetloo.

@ricmoo ricmoo closed this as completed Feb 13, 2021
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Feb 13, 2021
This was referenced Mar 12, 2021
Closed
Merged
Closed
Closed
This was referenced Apr 11, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricmoo