Is there any plans for @ethersproject/units to support TS 4.1.x

[glomotion]

We're currently trying to use @ethersproject/units (5.0.10) inside a react project which is built using a new version of TS:

"typescript": "^4.1.3",

currently, when trying to compile, we get the following type error from tsc:

node_modules/@ethersproject/experimental/lib/nonce-manager.d.ts:7:9 - error TS2611: 'provider' is defined as a property in class 'Signer', but is overridden here in 'NonceManager' as an accessor.

7     get provider(): ethers.providers.Provider;
          ~~~~~~~~

Found 1 error.

I've noticed that typescript 3.x is listed as a dev dependency for this repo:

"typescript": "3.8.3",

Just wondering if anyone else slammed into this?
If not, are there any plans to support newer TS installations?

[ricmoo]

I’m working on v6 right now which uses the latest greatest TS.

I don’t mind bumping the version up for v5 too though. I just need to communicate it because TS does make changes like this that can break people...

I’m surprised I haven’t ran into the above problem myself...

[feulf]

I'm running into this problem right now with typescript 4.1.5

[ricmoo]

I have put up a tweet seeking community feedback. If I haven't heard any compelling reasons by next week, I will bump the version and re-publish.

Any feedback is welcome!

Thanks! :)

[feulf]

Hi, are you thinking of a specific date for bumping to typescript 4.2.2?

[ricmoo]

Probably this weekend. I’ve given notice on Twitter and been using 4.2.2 for a week or so to make sure there are obvious no hiccups… I am currently using it in my local v6 branch and things seem fairly compatible. :)

[ricmoo]

Can you try out 5.0.32 and let me know how it works for you? It is using TypeScript 4.2.2.

[feulf]

I bumped both "ethers": "^5.0.32" and "typescript": "^4.2.2".

When I run npx tsc -p tsconfig.json I still get this errors:

node_modules/@ethersproject/providers/src.ts/base-provider.ts:1387:32 - error TS2322: Type 'null' is not assignable to type 'Resolver'.
...
node_modules/@ethersproject/providers/src.ts/json-rpc-provider.ts:279:13 - error TS2322: Type 'Networkish | undefined' is not assignable to type 'Networkish | Promise<Network>'.

Ideas?

[ricmoo]

Sounds like you have strict null checking enabled on libraries? V5 doesn’t support strict bull checking. There is an option on the tsconfig to disable checking libraries for strict...

[feulf]

I updated these 2 parameters in my tsconfig.json and it works fine now:

    "strict": false,
    "noImplicitAny": false,

Thanks @ricmoo!