Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache detectNetwork in WebSocketProvider #1054

Closed
ricmoo opened this issue Sep 18, 2020 · 2 comments
Closed

Cache detectNetwork in WebSocketProvider #1054

ricmoo opened this issue Sep 18, 2020 · 2 comments
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@ricmoo
Copy link
Member

ricmoo commented Sep 18, 2020

There is no need to validate chain ID on each call in a WebSocketProvider. It can be cached on connect.

#901 (comment)
@ricmoo ricmoo added enhancement New feature or improvement. on-deck This Enhancement or Bug is currently being worked on. labels Sep 18, 2020
@ricmoo ricmoo mentioned this issue Sep 18, 2020
Closed
ricmoo added a commit that referenced this issue Oct 5, 2020
@ricmoo
Cache chain ID for WebSocketProvider (#1054).
40264ff
@ricmoo
Copy link
Member Author

ricmoo commented Oct 6, 2020

I've fixed this in 5.0.16.

Try it out and let me know if it helps. :)

@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Oct 6, 2020
@ricmoo
Copy link
Member Author

ricmoo commented Oct 8, 2020

Closing this, but please re-open if you have any issues.

Thanks! :)

@ricmoo ricmoo closed this as completed Oct 8, 2020
@nionis nionis mentioned this issue Sep 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricmoo